[ 
https://issues.apache.org/jira/browse/NIFI-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15403224#comment-15403224
 ] 

ASF GitHub Bot commented on NIFI-2441:
--------------------------------------

GitHub user ijokarumawak opened a pull request:

    https://github.com/apache/nifi/pull/766

    NIFI-2441: View state fails with a JS error

    Removed permission check causing "Cannot read property 'canRead' of
    undefined". A given user won't have record level permission
    difference for component state. It's not required here.
    
    Before this fix, "View state" menu didn't show component state window, due 
to the JS error.
    
    Please clear the browser cache when you test this PR.
    You can test with whatever processor that manages its state, for example 
ListFile.
    
    
![image](https://cloud.githubusercontent.com/assets/1107620/17314638/dba8d1aa-58a0-11e6-9a00-af1366915295.png)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijokarumawak/nifi nifi-2441

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/766.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #766
    
----
commit ed8fd96ed3ecccba5196a2457591ba450b50bfa0
Author: Koji Kawamura <[email protected]>
Date:   2016-08-02T01:58:48Z

    NIFI-2441: View state fails with a JS error
    
    Removed permission check causing "Cannot read property 'canRead' of
    undefined". A given user won't have record level permission
    difference for component state. It's not required here.

----


> View state fails with a JS error: "Cannot read property 'canRead' of 
> undefined"
> -------------------------------------------------------------------------------
>
>                 Key: NIFI-2441
>                 URL: https://issues.apache.org/jira/browse/NIFI-2441
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core UI
>    Affects Versions: 1.0.0
>            Reporter: Koji Kawamura
>            Assignee: Koji Kawamura
>             Fix For: 1.0.0
>
>
> NIFI-2355 and its PR #715 added permission check to table sort comparator in 
> nf-component-state.js. And it produces a JS error: "Cannot read property 
> 'canRead' of undefined"
> I think it shouldn't be added to state table, since a given user won't have 
> record level permission difference for component state.
> #715 has the same change for changes nf-controller-services.js and other JS 
> files. I assume adding the permission change to nf-component-state.js was a 
> mistake. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to