[
https://issues.apache.org/jira/browse/NIFI-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15403365#comment-15403365
]
ASF GitHub Bot commented on NIFI-2291:
--------------------------------------
Github user YolandaMDavis commented on a diff in the pull request:
https://github.com/apache/nifi/pull/752#discussion_r73095094
--- Diff:
nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting/SiteToSiteProvenanceReportingTask.java
---
@@ -263,10 +271,15 @@ static JsonObject serialize(final JsonBuilderFactory
factory, final JsonObjectBu
addField(builder, "actorHostname", hostname);
if (nifiUrl != null) {
- final String urlPrefix =
nifiUrl.toString().replace(nifiUrl.getPath(), "");
- final String contentUriBase = urlPrefix +
"/nifi-api/controller/provenance/events/" + event.getEventId() + "/content/";
- addField(builder, "contentURI", contentUriBase + "output");
- addField(builder, "previousContentURI", contentUriBase +
"input");
+ // TO get URL Prefix, we just remove the /nifi from the end of
the URL. We know that the URL ends with
+ // "/nifi" because the Property Validator enforces it
+ final String urlString = nifiUrl.toString();
+ final String urlPrefix = urlString.substring(0,
urlString.length() - 5);
--- End diff --
Understood that validator enforces "/nifi" yet still seems to me like a
place to use the URL methods to build URL or perhaps reference a static
variable representing that string here (and in the Validator). Low likelihood
for that path to change but if it happened this would at least be a quick fix
or none required at all.
> Site-to-Site Provenance Reporting Task showing wrong content URI
> ----------------------------------------------------------------
>
> Key: NIFI-2291
> URL: https://issues.apache.org/jira/browse/NIFI-2291
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Reporter: Mark Payne
> Assignee: Mark Payne
> Fix For: 1.0.0
>
>
> I'm seeing the following JSON provided by the reporting task:
> {"eventId":"056aaf5c-476b-48fb-a252-55f9c6f42287",
> "eventOrdinal":113158283,
> "eventType":"ATTRIBUTES_MODIFIED",
> "timestampMillis":1468719367054,
> "timestamp":"2016-07-17T01:36:07.054Z",
> "durationMillis":-1,
> "lineageStart":1468718777766,
> "componentId":"f1550b29-5823-31c0-801d-d95770828ca9",
> "componentType":"UpdateAttribute",
> "componentName":"UpdateAttribute",
> "entityId":"14d23482-e2e6-4740-af6a-31059134feef",
> "entityType":"org.apache.nifi.flowfile.FlowFile",
> "entitySize":1431,
> "previousEntitySize":1431,
> "updatedAttributes":{},
> "previousAttributes":{"path":"./","execution.command":"python","filename":"5285482415879175","execution.command.args":"-m
>
> json.tool","execution.status":"0","reporting.task.transaction.id":"a3528aa7-674b-4de1-a65c-61ff0b094eac","execution.error":"","uuid":"14d23482-e2e6-4740-af6a-31059134feef"},
> "actorHostname":"nifi-02",
> "contentURI":"http:/-02:8080/nifi-api/controller/provenance/events/113158283/content/output",
> "previousContentURI":"http:/-02:8080/nifi-api/controller/provenance/events/113158283/content/input",
> "parentIds":[],
> "childIds":[],
> "platform":"nifi",
> "application":"NiFi Flow"}
> It appears that the "/nifi" is getting removed from the content URI - I think
> this has to do with the following block of code in the reporting task:
> `final String urlPrefix = nifiUrl.toString().replace(nifiUrl.getPath(), "");`
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
