[
https://issues.apache.org/jira/browse/NIFI-2425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15403920#comment-15403920
]
ASF GitHub Bot commented on NIFI-2425:
--------------------------------------
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/770
@olegz I just ran through some of these scenario's and everything looks
good so far. However, with the new UUID generation strategy I think there is
some dead code in SnippetUtils that should be cleaned up.
Specifically, in SnippetUtils#copyContentsForGroup there is a serviceIdMap
that was being used to update service identifiers in other component
properties. Can we remove this code to help clean that up? Specifically, I
think we can get rid of the serviceIdMap in SnippetUtils#copyContentsForGroup
as well as both of the overloaded
SnippetUtils#updateControllerServiceIdentifiers methods.
Please can a peek to make sure we're on the same page. Leaving this code in
place could lead to confusion down the road.
> Processors have invalid reference to controller service from template
> ---------------------------------------------------------------------
>
> Key: NIFI-2425
> URL: https://issues.apache.org/jira/browse/NIFI-2425
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.0.0
> Reporter: Bryan Bende
> Assignee: Oleg Zhurakousky
> Priority: Minor
> Fix For: 1.0.0
>
> Attachments: HiveProcessors.xml
>
>
> After importing and instantiating a template that existed before 1.0.0, the
> template imported without errors, and the controller service was created in
> the root group, but the two processors referencing it are invalid and show
> the UUID of the controller service rather than the name. This can easily be
> corrected by going into each processor's properties and changing the
> controller service selection, but should have been correct on import.
> Template is attached.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
