[ 
https://issues.apache.org/jira/browse/NIFI-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15404129#comment-15404129
 ] 

ASF GitHub Bot commented on NIFI-2452:
--------------------------------------

Github user joewitt commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/771#discussion_r73170934
  
    --- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/heartbeat/AbstractHeartbeatMonitor.java
 ---
    @@ -203,16 +203,24 @@ private void processHeartbeat(final NodeHeartbeat 
heartbeat) {
                 final DisconnectionCode disconnectionCode = 
connectionStatus.getDisconnectCode();
     
                 // Determine whether or not the node should be allowed to be 
in the cluster still, depending on its reason for disconnection.
    -            if (disconnectionCode == DisconnectionCode.LACK_OF_HEARTBEAT 
|| disconnectionCode == DisconnectionCode.UNABLE_TO_COMMUNICATE) {
    --- End diff --
    
    was this heartbeat stuff supposed to be in this PR?


> Provenance Repository's Index Readers can be prematurely closed
> ---------------------------------------------------------------
>
>                 Key: NIFI-2452
>                 URL: https://issues.apache.org/jira/browse/NIFI-2452
>             Project: Apache NiFi
>          Issue Type: Sub-task
>          Components: Core Framework
>            Reporter: Mark Payne
>            Assignee: Joseph Witt
>            Priority: Blocker
>             Fix For: 1.0.0
>
>
> I occasionally see when I run Provenance queries against an active provenance 
> repository that the JVM will crash, writing out an hs_err_pid_XXX.log file. 
> This appears to be related to 
> https://issues.apache.org/jira/browse/LUCENE-7183 which indicates that it's 
> caused by using a closed IndexReader.
> Adding to description from nice Github comments from mark:
> Ensure that we keep track of how many references we have to each lucene 
> searcher and only close the underlying index reader if there are no 
> references to the searcher. Also updated to prefer newer provenance events 
> over older provenance events, and calculate FlowFile lineage based on an 
> event id instead of a FlowFile UUID, as it's much more efficient



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to