Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/761#discussion_r73238512
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/processors/kafka/KafkaPublisher.java
---
@@ -233,12 +230,10 @@ void setProcessLog(ProcessorLog processLog) {
*/
private void warnOrError(String message, Exception e) {
if (e == null) {
- logger.warn(message);
if (this.processLog != null) {
--- End diff --
This feels a little off to me, @olegz - why not just pass the ComponentLog
in to the constructor? It should always be present.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
