[
https://issues.apache.org/jira/browse/NIFI-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405878#comment-15405878
]
ASF GitHub Bot commented on NIFI-1663:
--------------------------------------
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/727#discussion_r73332095
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/dbcp/hive/HiveConnectionPool.java
---
@@ -160,22 +162,9 @@
if (confFileProvided) {
final String configFiles =
validationContext.getProperty(HIVE_CONFIGURATION_RESOURCES).getValue();
- ValidationResources resources = validationResourceHolder.get();
-
- // if no resources in the holder, or if the holder has
different resources loaded,
- // then load the Configuration and set the new resources in
the holder
- if (resources == null ||
!configFiles.equals(resources.getConfigResources())) {
- getLogger().debug("Reloading validation resources");
- resources = new ValidationResources(configFiles,
HiveJdbcCommon.getConfigurationFromFiles(configFiles));
- validationResourceHolder.set(resources);
- }
-
- final Configuration hiveConfig = resources.getConfiguration();
final String principal =
validationContext.getProperty(kerberosProperties.getKerberosPrincipal()).getValue();
- final String keytab =
validationContext.getProperty(kerberosProperties.getKerberosKeytab()).getValue();
-
- problems.addAll(KerberosProperties.validatePrincipalAndKeytab(
- this.getClass().getSimpleName(), hiveConfig,
principal, keytab, getLogger()));
+ final String keyTab =
validationContext.getProperty(kerberosProperties.getKerberosKeytab()).getValue();
--- End diff --
I think the default properties include an empty set of properties, so it
shouldn't be null.
> Add support for ORC format
> --------------------------
>
> Key: NIFI-1663
> URL: https://issues.apache.org/jira/browse/NIFI-1663
> Project: Apache NiFi
> Issue Type: New Feature
> Reporter: Matt Burgess
> Assignee: Matt Burgess
> Fix For: 1.0.0
>
>
> From the Hive/ORC wiki
> (https://cwiki.apache.org/confluence/display/Hive/LanguageManual+ORC):
> The Optimized Row Columnar (ORC) file format provides a highly efficient way
> to store Hive data ... Using ORC files improves performance when Hive is
> reading, writing, and processing data.
> As users are interested in NiFi integrations with Hive (NIFI-981, NIFI-1193,
> etc.), NiFi should be able to support ORC file format to enable users to
> efficiently store flow files for use by Hive.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
