Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/727#discussion_r73332095
  
    --- Diff: 
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/dbcp/hive/HiveConnectionPool.java
 ---
    @@ -160,22 +162,9 @@
     
             if (confFileProvided) {
                 final String configFiles = 
validationContext.getProperty(HIVE_CONFIGURATION_RESOURCES).getValue();
    -            ValidationResources resources = validationResourceHolder.get();
    -
    -            // if no resources in the holder, or if the holder has 
different resources loaded,
    -            // then load the Configuration and set the new resources in 
the holder
    -            if (resources == null || 
!configFiles.equals(resources.getConfigResources())) {
    -                getLogger().debug("Reloading validation resources");
    -                resources = new ValidationResources(configFiles, 
HiveJdbcCommon.getConfigurationFromFiles(configFiles));
    -                validationResourceHolder.set(resources);
    -            }
    -
    -            final Configuration hiveConfig = resources.getConfiguration();
                 final String principal = 
validationContext.getProperty(kerberosProperties.getKerberosPrincipal()).getValue();
    -            final String keytab = 
validationContext.getProperty(kerberosProperties.getKerberosKeytab()).getValue();
    -
    -            problems.addAll(KerberosProperties.validatePrincipalAndKeytab(
    -                    this.getClass().getSimpleName(), hiveConfig, 
principal, keytab, getLogger()));
    +            final String keyTab = 
validationContext.getProperty(kerberosProperties.getKerberosKeytab()).getValue();
    --- End diff --
    
    I think the default properties include an empty set of properties, so it 
shouldn't be null. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to