[ 
https://issues.apache.org/jira/browse/NIFI-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405883#comment-15405883
 ] 

ASF GitHub Bot commented on NIFI-2322:
--------------------------------------

Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/741#discussion_r73333456
  
    --- Diff: 
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-pubsub-processors/src/main/java/org/apache/nifi/processors/kafka/pubsub/AbstractKafkaProcessor.java
 ---
    @@ -141,6 +166,10 @@
             SHARED_DESCRIPTORS.add(CLIENT_ID);
             SHARED_DESCRIPTORS.add(SECURITY_PROTOCOL);
             SHARED_DESCRIPTORS.add(KERBEROS_PRINCIPLE);
    +        SHARED_DESCRIPTORS.add(SSL_KEY_PASSWORD);
    --- End diff --
    
    This feels very odd to me to provide properties for the passwords but not 
the keystore and truststore. I do realize that the keystore and truststore can 
be specified via user-defined properties, but it adds to the complexity of 
configuring this, as the user has to lookup the appropriate property names. 
This is a usability miss.
    
    Why do we not simply expose a property for an SSLContextService? We could 
then pull the appropriate values from the SSLContextService via 
getKeyStorePassword(), getKeyStoreFile(), etc.


> ConsumeKafka gets stuck (cannot be stopped)
> -------------------------------------------
>
>                 Key: NIFI-2322
>                 URL: https://issues.apache.org/jira/browse/NIFI-2322
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: 1.0.0
>            Reporter: Haimo Liu
>            Assignee: Oleg Zhurakousky
>             Fix For: 1.0.0, 0.8.0
>
>         Attachments: Screen Shot 2016-07-19 at 2.14.32 PM.png, Screen Shot 
> 2016-07-19 at 2.14.48 PM.png
>
>
> If kafka broker path is invalid or inaccurate, ConsumeKafka processor can get 
> stuck (concurrent tasks cannot be stopped in a clustered mode). Please refer 
> to the images in the attachment. It appears that a configurable timeout 
> property would potentially solve the problem.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to