[
https://issues.apache.org/jira/browse/NIFI-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15409560#comment-15409560
]
Joseph Witt commented on NIFI-2491:
-----------------------------------
Similar to how processors should work the intent is that you're communicating
you either want this thing to run or do not want it to run. On each node how
successful that will be such as when or if it will be truly running may differ
but what should be consistent is that they're all trying to run. So it should
retry forever or until you disable/stop it. The code for that is here:
https://github.com/apache/nifi/blob/0.x/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/service/StandardControllerServiceNode.java#L279-L299
That said, in looking at the code you link i can see why you're thinking it is
a one-shot deal. I'm still looking into how that code relates to what I linked
above. Are you not seeing it attempt to restart the services?
> ControllerService startup issue
> -------------------------------
>
> Key: NIFI-2491
> URL: https://issues.apache.org/jira/browse/NIFI-2491
> Project: Apache NiFi
> Issue Type: Bug
> Reporter: Brandon DeVries
> Priority: Minor
>
> In the process of testing NIFI-2160 and NIFI-2344, we found that if a
> controller service throws some type of RuntimeException(e.g.
> IllegalStateException) in its @OnEnabled method it will essentially "break
> the chain" of startup of things that depend on it. The end result is that in
> a cluster, you can have a processor that is running on some nodes and stopped
> on others. This probably isn't the desired behavior. In
> StandardControllerServiceProvider\[1\] when thrown Exceptions are caught, we
> should possibly retry enabling the service. If it can't be enabled... we
> might want to consider shutting down NiFi. That's sort of extreme, but
> allowing the cluster to enter an inconsistent state seems like a bad thing.
> We could possibly also come up with some way of indicating there's an
> inconsistency in the UI. The proper solution will require some
> consideration, but the issue needs to be addressed somehow.
> \[1\]
> https://github.com/apache/nifi/blob/rel/nifi-0.7.0/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/service/StandardControllerServiceProvider.java#L320-L325
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
