[ 
https://issues.apache.org/jira/browse/NIFI-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15409940#comment-15409940
 ] 

ASF GitHub Bot commented on NIFI-2494:
--------------------------------------

Github user mcgilman commented on the issue:

    https://github.com/apache/nifi/pull/793
  
    @jskora Thanks for the PR. I just tried it out and was able to replicate 
the issue. However, with your proposed change, the heading text on the 
Controller Settings dialog is missing. This is accessed through the global menu 
and selecting 'Controller Settings'.
    
    I think the underlying issue is that the default visibility is not being 
set on the settings dialog [1]. By adding `class="hidden"` to the settings div, 
I believe the issue is resolved. Would you mind trying that locally and if you 
agree update the PR?
    
    Thanks again!
    
    [1] 
https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/WEB-INF/partials/canvas/settings-content.jsp#L18
 


> Remove extraneous text that shows on banner line
> ------------------------------------------------
>
>                 Key: NIFI-2494
>                 URL: https://issues.apache.org/jira/browse/NIFI-2494
>             Project: Apache NiFi
>          Issue Type: Sub-task
>          Components: Core UI
>    Affects Versions: 1.0.0
>            Reporter: Joe Skora
>            Assignee: Joe Skora
>            Priority: Trivial
>
> The words "NiFi Settings" appear on the top left of the page, on the banner 
> line.  They appear to be included in the page render and the banner message 
> is rendered as background so the text is not overwritten.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to