[ 
https://issues.apache.org/jira/browse/NIFI-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412456#comment-15412456
 ] 

ASF GitHub Bot commented on NIFI-2507:
--------------------------------------

Github user jvwing commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/801#discussion_r73953158
  
    --- Diff: 
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/AbstractS3Processor.java
 ---
    @@ -82,6 +83,15 @@
                 .description("A comma-separated list of Amazon User ID's or 
E-mail addresses that specifies who should have permissions to change the 
Access Control List for an object")
                 .defaultValue("${s3.permissions.writeacl.users}")
                 .build();
    +    public static final PropertyDescriptor CANNED_ACL = new 
PropertyDescriptor.Builder()
    +            .name("Canned ACL")
    --- End diff --
    
    Would you please use `name()` as a property key ("canned-acl") and use 
`displayName()` for the UI ("Canned ACL")?  I know you matched the existing 
code, but we're trying to move to the name+displayName standard.


> PutS3Object should support Canned ACLs
> --------------------------------------
>
>                 Key: NIFI-2507
>                 URL: https://issues.apache.org/jira/browse/NIFI-2507
>             Project: Apache NiFi
>          Issue Type: Improvement
>    Affects Versions: 0.7.0
>            Reporter: Tim Reardon
>            Assignee: James Wing
>            Priority: Minor
>
> In order to support cross-account scenarios, PutS3Object should support 
> specifying canned ACL's such as "bucket-owner-full-control".
> See 
> http://docs.aws.amazon.com/AmazonS3/latest/dev/acl-overview.html#canned-acl



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to