Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/827#discussion_r74425691
--- Diff:
nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java
---
@@ -106,26 +69,17 @@
.addValidator(StandardValidators.PORT_VALIDATOR)
.build();
- protected static final PropertyDescriptor SMTP_HOSTNAME = new
PropertyDescriptor.Builder()
- .name("SMTP_HOSTNAME")
- .displayName("SMTP hostname")
- .description("The hostname to be embedded into the banner
displayed when an " +
- "SMTP client connects to the processor TCP port .")
- .required(true)
- .expressionLanguageSupported(false)
- .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
- .build();
-
- protected static final PropertyDescriptor SMTP_MAXIMUM_CONNECTIONS =
new PropertyDescriptor.Builder()
+ static final PropertyDescriptor SMTP_MAXIMUM_CONNECTIONS = new
PropertyDescriptor.Builder()
.name("SMTP_MAXIMUM_CONNECTIONS")
.displayName("Maximum number of SMTP connection")
.description("The maximum number of simultaneous SMTP
connections.")
.required(true)
+ .defaultValue("1")
.expressionLanguageSupported(false)
.addValidator(StandardValidators.INTEGER_VALIDATOR)
.build();
- protected static final PropertyDescriptor SMTP_TIMEOUT = new
PropertyDescriptor.Builder()
+ static final PropertyDescriptor SMTP_TIMEOUT = new
PropertyDescriptor.Builder()
--- End diff --
I have no intention to speak SMTP. I am relying on the underlying API to do
that and if it's inadequate, then let's look for a better API.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
