[ 
https://issues.apache.org/jira/browse/NIFI-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15419214#comment-15419214
 ] 

ASF GitHub Bot commented on NIFI-2551:
--------------------------------------

GitHub user markap14 opened a pull request:

    https://github.com/apache/nifi/pull/847

    NIFI-2551: Addressed a threading issue in the StandardResourceClaimManager…

    … and performed some refactoring so that we can ensure thread-safety across 
different components of the application, such as ProcessSession and 
WriteAheadFlowFile Repository when interacting with the 
StandardResourceClaimManager. Update DebugFlow to allow it to write to a 
FlowFile multiple times, which exposes the concurrency bug. Also avoided 
calling ContentRepository.remove() from ProcessSession whenever the content is 
no longer needed, as that can cause problems now that the Resource Claim is 
backing the content claim.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markap14/nifi NIFI-2551

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/847.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #847
    
----
commit ec79ff0d6a595a969cf65ca9cd65d51caab08620
Author: Mark Payne <[email protected]>
Date:   2016-08-12T17:56:03Z

    NIFI-2551: Addressed a threading issue in the StandardResourceClaimManager 
and performed some refactoring so that we can ensure thread-safety across 
different components of the application, such as ProcessSession and 
WriteAheadFlowFile Repository when interacting with the 
StandardResourceClaimManager. Update DebugFlow to allow it to write to a 
FlowFile multiple times, which exposes the concurrency bug. Also avoided 
calling ContentRepository.remove() from ProcessSession whenever the content is 
no longer needed, as that can cause problems now that the Resource Claim is 
backing the content claim.

----


> Rare condition causes FileSystemRepository NPE
> ----------------------------------------------
>
>                 Key: NIFI-2551
>                 URL: https://issues.apache.org/jira/browse/NIFI-2551
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 1.0.0, 0.7.0
>            Reporter: Michael Moser
>            Assignee: Michael Moser
>            Priority: Blocker
>
> In rare unpredictable cases when NiFi is processing a heavy load, we see 
> FileSystemRepository throw a NullPointerException
> {noformat}
> java.lang.NullPointerException
>     at o.a.n.c.r.FileSystemRepository$2.write(FileSystemRepository.java:918) 
> [nifi-framework-core-0.7.0.jar]
>     at 
> o.a.n.c.r.io.DisableOnCloseOutputStream.write(DisableOnCloseOutputStream.java:49)
>     ....
>     Suppressed: java.lang.NullPointerException
>         at 
> o.a.n.c.r.FileSystemRepository$2.flush(FileSystemRepository.java:934) 
> [nifi-framework-core-0.7.0.jar]
>         at 
> o.a.n.c.r.io.DisableOnCloseOutputStream.close(DisableOnCloseOutputStream.java:68)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to