Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/836#discussion_r74754536
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardProcessorNode.java
---
@@ -1321,12 +1325,21 @@ public void run() {
this.unscheduled = true;
}
try {
- if (activeThreadMonitorCallback.call()) {
+ if (scheduleState.isScheduled()) {
+
schedulingAgent.unschedule(StandardProcessorNode.this, scheduleState);
+ }
--- End diff --
I am ok with whatever decision but just to clarify; Logic for
scheduling/unscheduling was tightly encapsulated in
```StandardProcessScheduler``` where it had access to other things that may be
required to perform scheduling/unscheduling operations. A callback could always
be modified without introducing any changes to ```ProcessNode```. I am simply
afraid that doing the above may lead to dragging more things into
```ProcessNode``` from ```StandardProcessScheduler``` which will eventually
lead to package dependency cycles and all the nasty stuff it brings with it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
