Github user mosermw commented on a diff in the pull request:
https://github.com/apache/nifi/pull/848#discussion_r74800253
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/FileSystemRepository.java
---
@@ -953,7 +941,7 @@ public synchronized void close() throws IOException {
// is called. In this case, we don't have to actually
close the file stream. Instead, we
// can just add it onto the queue and continue to use it
for the next content claim.
final long resourceClaimLength = scc.getOffset() +
scc.getLength();
- if (recycle && resourceClaimLength < maxAppendClaimLength)
{
+ if (recycle && resourceClaimLength <
MAX_APPENDABLE_CLAIM_LENGTH) {
// we do not have to synchronize on the writable claim
queue here because we
// are only adding something to the queue. We must
synchronize if we are
// using a ResourceClaim from the queue and
incrementing the claimant count on that resource
--- End diff --
Another comment that longer applies. Leaving it in might confuse our
future selves.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
