Joseph Witt created NIFI-2610:
---------------------------------
Summary: TestProcessorLifecycle class causes brittle builds and
appears to be an integration test
Key: NIFI-2610
URL: https://issues.apache.org/jira/browse/NIFI-2610
Project: Apache NiFi
Issue Type: Bug
Reporter: Joseph Witt
Fix For: 1.0.0
The tests in TestProcessorLifecycle appear to be attempting to replicate
various threading scenarios. Such tests are notoriously difficult to get right
and indeed the build is brittle as a result. These tests are likely valuable
and should be improved but they also should be considered integration tests it
appears.
Tests run: 16, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 42.708 sec <<<
FAILURE! - in org.apache.nifi.controller.scheduling.TestProcessorLifecycle
validateSuccessfullAndOrderlyShutdown(org.apache.nifi.controller.scheduling.TestProcessorLifecycle)
Time elapsed: 6.313 sec <<< FAILURE!
java.lang.AssertionError: expected:<3> but was:<2>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:645)
at org.junit.Assert.assertEquals(Assert.java:631)
at
org.apache.nifi.controller.scheduling.TestProcessorLifecycle.validateSuccessfullAndOrderlyShutdown(TestProcessorLifecycle.java:224)
Brittle tests like this risk the build process which harms the review cycle and
complicates release voting.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
