[
https://issues.apache.org/jira/browse/NIFI-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15432395#comment-15432395
]
ASF GitHub Bot commented on NIFI-2621:
--------------------------------------
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/909
Reviewed, ran the tool with 20 identical hostnames. The build passed with
the new tests and checkstyle was fine. Merged to master and closed the ticket.
> NiFi CertificateUtils can reuse serial numbers in issued certificates if
> multiple calls are made in the same millisecond
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: NIFI-2621
> URL: https://issues.apache.org/jira/browse/NIFI-2621
> Project: Apache NiFi
> Issue Type: Bug
> Reporter: Bryan Rosander
> Assignee: Bryan Rosander
>
> Serial numbers on certificates should be unique. CertificateUtils currently
> uses System.currentTimeMillis() to generate them.
> Proposed solution:
> 1. Use the current time in millis as the most significant part of the serial
> number
> 2. Shift it left 32 bits to make room in the BigInteger for an incrementor
> value
> 3. Add the incrementor value to the BigInteger
> 4. Reset the incrementor every time a the generator function is called and
> the millisecond is different from before
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
