Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/914#discussion_r75859429
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/test/java/org/apache/nifi/hbase/MockHBaseClientService.java
---
@@ -131,4 +131,48 @@ public void setThrowException(boolean throwException) {
public byte[] toBytes(final String s) {
return s.getBytes(StandardCharsets.UTF_8);
}
+
+ @Override
+ //Implementation of this and the isHexDigit and toBinaryFromHex are
from HBase Bytes.java
+ public byte[] toBytesBinary(String s) {
--- End diff --
I'm wondering if we should declare a test dependency on HBase 1.1.2 so that
we don't need to copy this code, or if its better/easier to just copy this code
we might need to put something in our notice or license to attribute it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
