GitHub user ijokarumawak opened a pull request:

    https://github.com/apache/nifi/pull/956

    NIFI-2480: Fix for multibyte chars in breadcrumbs

    Removed $sanitize from breadcrumbs controller, as it escapes multibyte 
chars with numerical reference, and non-English names are not displayed in 
human readable way.
    Even without $sanitize, html tags can be escaped when Angular binds the 
value to text content.
    
    I confirmed that HTML tags are escaped without $sanitize as following 
screen-shots:
    
    
![image](https://cloud.githubusercontent.com/assets/1107620/17996071/745b2084-6ba1-11e6-9f4a-ae98fc6a8702.png)
    
    I hope this can be merged, and it doesn't have any negative impact by 
removing $sanitize.
    
    Thanks!

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijokarumawak/nifi nifi-2480

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/956.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #956
    
----
commit a5d643337b78e65829d03a69e4af11ef8bef4708
Author: Koji Kawamura <[email protected]>
Date:   2016-08-26T05:56:23Z

    NIFI-2480: Fix for multibyte chars in breadcrumbs
    
    Removed $sanitize from breadcrumbs controller, as it escapes multibyte
    chars with numerical reference. Even without $sanitize, html tags can be
    escaped when Angular binds the value to text content.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to