[ 
https://issues.apache.org/jira/browse/NIFI-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15468329#comment-15468329
 ] 

ASF GitHub Bot commented on NIFI-2732:
--------------------------------------

Github user markap14 commented on the issue:

    https://github.com/apache/nifi/pull/987
  
    With the new commit, all looks good from a code review perspective. I 
haven't yet had a chance to test ConsumeKafka0_10, though I did test 
ConsumeKafka and that all worked as expected. Once I've had a chance to test 
ConsumeKafka0_10 I'll be happy to merge. Or if anyone else has a chance to 
verify it, please feel free to merge it as well.


> ConsumeKafka 0.9 and 0.10 not handling partition reassignment case 
> sufficiently
> -------------------------------------------------------------------------------
>
>                 Key: NIFI-2732
>                 URL: https://issues.apache.org/jira/browse/NIFI-2732
>             Project: Apache NiFi
>          Issue Type: Bug
>            Reporter: Joseph Witt
>            Assignee: Joseph Witt
>            Priority: Critical
>             Fix For: 1.1.0
>
>
> The new ConsumeKafka clients handle the threading model of the consumer api 
> correctly.  However, they are not yet honoring partition reassignment cases 
> sufficiently which means we could have avoidable cases of duplication.  By 
> registering a partition reassignment listener we can handle it correctly.
> Further, the processor is loading subsequent polls of messages into memory 
> rather than writing directly to the process session/disk.  We could write 
> them to disk and achieve far better performance and efficiency.  Early 
> testing shows easily achieving 100MB/s sustained per thread on a simple 
> laptop setup with defaults which will scale very nicely on a legit installed 
> content repository.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to