[
https://issues.apache.org/jira/browse/NIFI-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15481805#comment-15481805
]
ASF GitHub Bot commented on NIFI-2684:
--------------------------------------
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/1002
@trixpan from DRY/readability perspective consider creating the builder
ahead of the if/else. So an alternative approach would look like this
(formatting aside)
`
ValidationResult.Builder builder = new
ValidationResult.Builder().valid(false).input(null).subject(descriptor.getDisplayName());
builder = (descriptor.getDisplayName() != null) ?
builder.explanation(descriptor.getDisplayName() + " is required") :
.explanation(descriptor.getName() + " is required");
results.add(builder.build());
`
> Validation error messages should refer to propertyDescriptor using its
> displayName
> ----------------------------------------------------------------------------------
>
> Key: NIFI-2684
> URL: https://issues.apache.org/jira/browse/NIFI-2684
> Project: Apache NiFi
> Issue Type: Improvement
> Affects Versions: 1.0.0
> Reporter: Andre
> Assignee: Andre
> Fix For: 1.1.0
>
>
> When certain validation violation are triggered,
> {{AbstractConfigurableComponent}} refers to the descriptor using
> {{descriptor.getName()}}
> the result is that error messages end up referring to properties by sometimes
> cryptic names (instead of the "pretty names" defined in {{.displayName}} )
> Users would be better of if we used {{displayName}} on error messages when
> available, but to fallback to names in case displayName is null.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
