Github user markap14 commented on the issue:

    https://github.com/apache/nifi/pull/1000
  
    @patricker @mcgilman looking at the PR, I do think that this will resolve 
the specific use case that you're running into, Peter. I think, though, that it 
is addressing a very specific corner case and could actually be solved a little 
more generally, though. Instead of changing the number of swap files based on 
the specific condition of `activeQueue.size() == 0 && numSwapFiles > 0 && 
swapQueue.size() % SWAP_RECORD_POLL_SIZE == 0` what do you think of just 
calling `migrateSwapToActive()` at the beginning of the 
`writeSwapFilesIfNecessary()`? This should also ensure that we keep with the 
same ordering guarantees that we have provided throughout the rest of the class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to