[
https://issues.apache.org/jira/browse/NIFI-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15488484#comment-15488484
]
ASF GitHub Bot commented on NIFI-2266:
--------------------------------------
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/999
And, of course, as soon as I comment, it hits me -- `GetHTTP`, unlike
`PostHTTP`, does not require a flowfile input in order to execute. So when I
copied the tests I had written for `PostHTTP`, I needed to either remove the
`enqueue` action of the message content prior to running, or assert that 2
flowfiles succeeded (the one manually enqueued and the result of the `GET`
call). I think the current code is correct and successful, but if desired, I
can push my latest changes which remove the manual enqueuing and assert
explicitly 1 flowfile succeeded.
> GetHTTP and PutHTTP use hard-coded TLS protocol version
> -------------------------------------------------------
>
> Key: NIFI-2266
> URL: https://issues.apache.org/jira/browse/NIFI-2266
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 0.7.0, 0.6.1
> Reporter: Andy LoPresto
> Assignee: Andy LoPresto
> Labels: https, security, tls
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> As pointed out on the mailing list [1], the {{GetHTTP}} (and likely
> {{PutHTTP}}) processors use a hard-coded TLS protocol version. {{PostHTTP}}
> also did this and was fixed by [NIFI-1688].
> The same fix should apply here and unit tests already exist which can be
> applied to the other processors as well.
> For future notice, {{InvokeHTTP}} is a better processor for generic HTTP
> operations and has supported reading the TLS protocol version from the
> {{SSLContextService}} for some time.
> [1]
> https://lists.apache.org/thread.html/a48e2ebbc2231d685491ae6b856c760620efca5bff2c7249f915b24d@%3Cdev.nifi.apache.org%3E
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
