[GitHub] nifi pull request #803: nifi-1214c Mock Framework should allow order-indepen...

[ToivoAdams]

Github user ToivoAdams commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/803#discussion_r79117053
  
    --- Diff: nifi-mock/src/main/java/org/apache/nifi/util/MockFlowFile.java ---
    @@ -290,4 +291,18 @@ public long getLineageStartIndex() {
         public long getQueueDateIndex() {
             return 0;
         }
    +
    +    public boolean isAttributeEqual(final String attributeName, final 
String expectedValue) {
    +        // unknown attribute name, so cannot be equal.
    +        if (attributes.containsKey(attributeName) == false)
    +            return false;
    +
    +        String value = attributes.get(attributeName);
    +        return Objects.equals(expectedValue, value);
    +    }
    +
    +    public boolean isContentEqual(String excpected) {
    +        final String value = new String(this.data, 
Charset.forName("UTF-8"));
    +        return Objects.equals(excpected, value);
    --- End diff --
    
    Hi @JPercivall,
    
    Thanks for reviewing.
    
    Maybe I misunderstood, but assertContentEquals methods don’t return 
boolean and won’t work with Predicate’s.
    
    For example, I can’t use assertContentEquals here (instead of 
isContentEqual)
    ```java
            runner.assertAllConditionsMet("success",
                mff -> mff.isAttributeEqual("GROUP_ATTRIBUTE_KEY", "1") && 
mff.isContentEqual("1,hello\n1,good-bye")
            );
    ```
    
    isContentEqual parameter could be byte[] array.
    But I think its convenient to have String parameter also, maybe 2 
overloaded methods?
    
    Thanks
    Toivo


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---