[ 
https://issues.apache.org/jira/browse/NIFI-2810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15516549#comment-15516549
 ] 

ASF GitHub Bot commented on NIFI-2810:
--------------------------------------

Github user pvillard31 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1034#discussion_r80250891
  
    --- Diff: 
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/test/java/org/apache/nifi/processors/aws/s3/ITPutS3Object.java
 ---
    @@ -238,6 +238,26 @@ public void testMetaData() throws IOException {
         }
     
         @Test
    +    public void testContentType() throws IOException {
    +        PutS3Object processor = new PutS3Object();
    +        final TestRunner runner = TestRunners.newTestRunner(processor);
    +
    +        runner.setProperty(PutS3Object.CREDENTIALS_FILE, CREDENTIALS_FILE);
    +        runner.setProperty(PutS3Object.REGION, REGION);
    +        runner.setProperty(PutS3Object.BUCKET, BUCKET_NAME);
    +        runner.setProperty(PutS3Object.CONTENT_TYPE, "text/plain");
    +
    +        runner.enqueue(getResourcePath(SAMPLE_FILE_RESOURCE_NAME));
    +
    +        runner.run();
    +
    +        runner.assertAllFlowFilesTransferred(PutS3Object.REL_SUCCESS, 1);
    +        List<MockFlowFile> flowFiles = 
runner.getFlowFilesForRelationship(PutS3Object.REL_SUCCESS);
    +        MockFlowFile ff1 = flowFiles.get(0);
    +        ff1.assertAttributeEquals(PutS3Object.S3_CONTENT_TYPE, 
"text/plain");
    --- End diff --
    
    If I understand the unit test correctly, there will be a new attribute 
written into the flow file (``s3.contenttype``). Could you add the 
corresponding ``@WritesAttribute`` annotation at the top of the ``PutS3Object`` 
class?


> Allow Content Type to be set in PutS3Object processor
> -----------------------------------------------------
>
>                 Key: NIFI-2810
>                 URL: https://issues.apache.org/jira/browse/NIFI-2810
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>    Affects Versions: 1.1.0
>            Reporter: Edgardo Vega
>            Priority: Minor
>             Fix For: 1.1.0
>
>
> The PutS3 Processor does not allow you to set the Content Type. Add this 
> ability in this processor



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to