adamdebreceni commented on a change in pull request #807:
URL: https://github.com/apache/nifi-minifi-cpp/pull/807#discussion_r452651022
##########
File path: libminifi/src/core/ProcessGroup.cpp
##########
@@ -353,6 +353,10 @@ void ProcessGroup::getConnections(std::map<std::string,
std::shared_ptr<Connecta
connectionMap[connection->getUUIDStr()] = connection;
connectionMap[connection->getName()] = connection;
}
+ for (auto processor : processors_) {
+ // processors can also own FlowFiles
+ connectionMap[processor->getUUIDStr()] = processor;
Review comment:
agree, the main source of confusion is that `getConnections` expects a
`std::map<std::string, std::shared_ptr<Connectable>>&` and `Processor` is
`Connectable`
notice that there is a `getConnections` right above this method which
expects a `std::map<std::string, std::shared_ptr<Connection>>&`, there should
be a separate interface indicating FlowFile ownership capabilities, and
`Connection` should not be `Connectable` (should do after the release)
for now I'll create a new method like `getFlowFileContainers` to better
indicate what it's used for
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
