[
https://issues.apache.org/jira/browse/MINIFICPP-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Hunyadi updated MINIFICPP-1267:
------------------------------------
Description:
*Background:*
The processor called ConvertUpdate does not seem to work as intended (or is
full of useless noise). This code part shows clear signs of misbehaviour:
{code:c++|title=ConvetUpdate::onTrigger(...)}
std::string returnTopic, url;
if (returnTopic.empty() || url.empty()) {
logger_->log_debug("topic and/or URL are empty");
break;
}
{code}
*Proposal:*
One should investigate the purpose of this processor, fix it and add tests.
was:
*Background:*
The processor called ConvertUpdate does not seem to work as intended (or is
full of useless noise). This code part shows clear signs of misbehaviour:
{code:c++|title=ConvetUpdate::onTrigger(...)}
std::string returnTopic, url;
if (returnTopic.empty() || url.empty()) {
logger_->log_debug("topic and/or URL are empty");
break;
}
{code}
*Proposal:*
One should investigate the purpose of this processor, fix it and add tests.
> Fix or decommission ConvertUpdate processor
> -------------------------------------------
>
> Key: MINIFICPP-1267
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1267
> Project: Apache NiFi MiNiFi C++
> Issue Type: Improvement
> Affects Versions: 0.7.0
> Reporter: Adam Hunyadi
> Priority: Minor
> Labels: MiNiFi-CPP-Hygiene
> Fix For: 1.0.0
>
>
> *Background:*
> The processor called ConvertUpdate does not seem to work as intended (or is
> full of useless noise). This code part shows clear signs of misbehaviour:
> {code:c++|title=ConvetUpdate::onTrigger(...)}
> std::string returnTopic, url;
> if (returnTopic.empty() || url.empty()) {
> logger_->log_debug("topic and/or URL are empty");
> break;
> }
> {code}
> *Proposal:*
> One should investigate the purpose of this processor, fix it and add tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
