MuazmaZ commented on a change in pull request #4369:
URL: https://github.com/apache/nifi/pull/4369#discussion_r452971444
##########
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/AbstractAzureDataLakeStorageProcessor.java
##########
@@ -33,66 +33,26 @@
import org.apache.commons.lang3.StringUtils;
import org.apache.nifi.components.PropertyDescriptor;
-import org.apache.nifi.components.ValidationContext;
-import org.apache.nifi.components.ValidationResult;
import org.apache.nifi.components.Validator;
import org.apache.nifi.context.PropertyContext;
import org.apache.nifi.expression.ExpressionLanguageScope;
import org.apache.nifi.flowfile.FlowFile;
import org.apache.nifi.processor.AbstractProcessor;
import org.apache.nifi.processor.Relationship;
import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.services.azure.storage.ADLSCredentialsDetails;
+import org.apache.nifi.services.azure.storage.ADLSCredentialsService;
+import reactor.core.publisher.Mono;
public abstract class AbstractAzureDataLakeStorageProcessor extends
AbstractProcessor {
- public static final PropertyDescriptor ACCOUNT_NAME = new
PropertyDescriptor.Builder()
- .name("storage-account-name").displayName("Storage Account Name")
- .description("The storage account name. There are certain risks
in allowing the account name to be stored as a flowfile " +
- "attribute. While it does provide for a more flexible flow
by allowing the account name to " +
- "be fetched dynamically from a flowfile attribute, care
must be taken to restrict access to " +
- "the event provenance data (e.g. by strictly controlling
the policies governing provenance for this Processor). " +
- "In addition, the provenance repositories may be put on
encrypted disk partitions." +
- " Instead of defining the Storage Account Name, Storage
Account Key and SAS Token properties directly on the processor, " +
- "the preferred way is to configure them through a
controller service")
- .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
-
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
- .required(true)
- .sensitive(true).build();
-
- public static final PropertyDescriptor ACCOUNT_KEY = new
PropertyDescriptor.Builder()
- .name("storage-account-key").displayName("Storage Account Key")
- .description("The storage account key. This is an admin-like
password providing access to every container in this account. It is recommended
" +
- "one uses Shared Access Signature (SAS) token instead for
fine-grained control with policies. " +
- "There are certain risks in allowing the account key to be
stored as a flowfile " +
- "attribute. While it does provide for a more flexible flow
by allowing the account key to " +
- "be fetched dynamically from a flow file attribute, care
must be taken to restrict access to " +
- "the event provenance data (e.g. by strictly controlling
the policies governing provenance for this Processor). " +
- "In addition, the provenance repositories may be put on
encrypted disk partitions.")
- .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
-
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
- .required(false)
- .sensitive(true).build();
-
- public static final PropertyDescriptor SAS_TOKEN = new
PropertyDescriptor.Builder()
- .name("storage-sas-token").displayName("SAS Token")
- .description("Shared Access Signature token, including the leading
'?'. Specify either SAS Token (recommended) or Account Key. " +
- "There are certain risks in allowing the SAS token to be
stored as a flowfile " +
- "attribute. While it does provide for a more flexible flow
by allowing the account name to " +
- "be fetched dynamically from a flowfile attribute, care
must be taken to restrict access to " +
- "the event provenance data (e.g. by strictly controlling
the policies governing provenance for this Processor). " +
- "In addition, the provenance repositories may be put on
encrypted disk partitions.")
- .required(false)
-
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
- .sensitive(true)
- .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
- .build();
-
- public static final PropertyDescriptor USE_MANAGED_IDENTITY = new
PropertyDescriptor.Builder()
- .name("use-managed-identity")
- .displayName("Use Azure Managed Identity")
- .description("Choose whether or not to use the managed identity of
Azure VM/VMSS ")
- .required(false).defaultValue("false").allowableValues("true",
"false")
- .addValidator(StandardValidators.BOOLEAN_VALIDATOR).build();
+ public static final PropertyDescriptor CREDENTIALS_SERVICE = new
PropertyDescriptor.Builder()
Review comment:
Blob property is named as STORAGE_CREDENTIALS_SERVICE, would need to
clean up that as separate PR to avoid confusion.
being specific like ADLS_CREDENTIALS_SERVICE would be clear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
