hunyadi-dev commented on a change in pull request #821:
URL: https://github.com/apache/nifi-minifi-cpp/pull/821#discussion_r454397770
##########
File path: libminifi/include/core/PropertyValidation.h
##########
@@ -259,6 +259,22 @@ class UnsignedLongValidator : public PropertyValidator {
}
};
+class NonBlankValidator : public PropertyValidator {
+ public:
+ explicit NonBlankValidator(const std::string& name)
+ : PropertyValidator(name) {
+ }
+ ~NonBlankValidator() override = default;
+
+ ValidationResult validate(const std::string& subject, const
std::shared_ptr<minifi::state::response::Value>& input) const final {
+ return validate(subject, input->getStringValue());
Review comment:
I thought yaml parsing ignored padding, so
```yaml
name: A
```
was the same as
```yaml
name: A
```
Will add trimming for the string.
##########
File path: libminifi/include/core/PropertyValidation.h
##########
@@ -259,6 +259,22 @@ class UnsignedLongValidator : public PropertyValidator {
}
};
+class NonBlankValidator : public PropertyValidator {
+ public:
+ explicit NonBlankValidator(const std::string& name)
+ : PropertyValidator(name) {
+ }
+ ~NonBlankValidator() override = default;
+
+ ValidationResult validate(const std::string& subject, const
std::shared_ptr<minifi::state::response::Value>& input) const final {
+ return validate(subject, input->getStringValue());
Review comment:
I thought yaml parsing ignored padding, so
```yaml
name: A
```
was the same as
```yaml
name: A
```
**Will add trimming for the string.**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
