adamdebreceni commented on a change in pull request #807:
URL: https://github.com/apache/nifi-minifi-cpp/pull/807#discussion_r454824460



##########
File path: libminifi/include/core/Repository.h
##########
@@ -228,6 +232,8 @@ class Repository : public virtual 
core::SerializableComponent, public core::Trac
   Repository &operator=(const Repository &parent) = delete;
 
  protected:
+  std::map<std::string, std::shared_ptr<core::Connectable>> containers;

Review comment:
       currently `Connectable` declares the `put` method, meaning that 
`Connectable`s are exactly what can be containers, later I would like if we had 
a `FlowFileContainer` class and separate this capability out




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to