hunyadi-dev commented on a change in pull request #837:
URL: https://github.com/apache/nifi-minifi-cpp/pull/837#discussion_r455637198
##########
File path: libminifi/include/core/PropertyValidation.h
##########
@@ -202,7 +202,7 @@ class UnsignedIntValidator : public PropertyValidator {
class LongValidator : public PropertyValidator {
public:
- explicit LongValidator(const std::string &name, int64_t min =
(std::numeric_limits<int64_t>::min)(), int64_t max =
(std::numeric_limits<int64_t>::max)())
+ explicit LongValidator(const std::string &name, int64_t min =
std::numeric_limits<int64_t>::min(), int64_t max =
(std::numeric_limits<int64_t>::max)())
Review comment:
Good catch, removed.
##########
File path: libminifi/src/utils/file/FileUtils.cpp
##########
@@ -40,7 +40,7 @@ uint64_t FileUtils::computeChecksum(const std::string
&file_name, uint64_t up_to
while (stream && remaining_bytes_to_be_read > 0) {
// () around std::min are needed because Windows.h defines min (and max)
as a macro
Review comment:
Good catch, removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
