pvillard31 commented on a change in pull request #4321:
URL: https://github.com/apache/nifi/pull/4321#discussion_r456345824



##########
File path: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/CompressContent.java
##########
@@ -124,7 +126,7 @@
         .build();
     public static final PropertyDescriptor MODE = new 
PropertyDescriptor.Builder()
     .name("Mode")
-    .description("Indicates whether the processor should compress content or 
decompress content. Must be either 'compress' or 'decompress'")
+    .description("Indicates whether the processor should compress content or 
decompress content. Must be either 'compress' or 'decompress'. Data that is 
compressed with Snappy Hadoop can not be decomressed using this processor.")

Review comment:
       Instead of updating the description, could we add a customValidate 
method to make the processor invalid in case both SNAPPY HADOOP is selected for 
the compression format and DECOMPRESS is selected for the mode?

##########
File path: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/CompressContent.java
##########
@@ -124,7 +126,7 @@
         .build();
     public static final PropertyDescriptor MODE = new 
PropertyDescriptor.Builder()
     .name("Mode")
-    .description("Indicates whether the processor should compress content or 
decompress content. Must be either 'compress' or 'decompress'")
+    .description("Indicates whether the processor should compress content or 
decompress content. Must be either 'compress' or 'decompress'. Data that is 
compressed with Snappy Hadoop can not be decomressed using this processor.")

Review comment:
       ```suggestion
       .description("Indicates whether the processor should compress content or 
decompress content. Must be either 'compress' or 'decompress'. Data that is 
compressed with Snappy Hadoop can not be decompressed using this processor.")
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to