pvillard31 commented on pull request #4420: URL: https://github.com/apache/nifi/pull/4420#issuecomment-662568110
Playing with it and it's awesome, thanks @simonbence for this pull request! Minor suggestions at the moment: - ordering of the metrics on the UI side, I'd probably to group things together like: load stats, heap stats, repo stats, gc stats, file handler, etc. Not sure how easy it'd be. - there is the total number of threads which is great, it would be nice to also have the number of threads being used from the Timer Driven Thread pool, the number of threads being used from the Event Driven Thread pool. That would be great. Not sure if we display two lines on the same graph, but if possible, displaying the size value of the pool (basically the maximum the value can be over time) would be nice. That would be particularly useful to see if the thread pool is oversized or not. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
