adamdebreceni commented on a change in pull request #848:
URL: https://github.com/apache/nifi-minifi-cpp/pull/848#discussion_r463404637
##########
File path: libminifi/include/io/Serializable.h
##########
@@ -44,8 +44,9 @@ Integral byteSwap(Integral i) {
#ifdef htonll
return htonll(i);
#else
- #define htonll_r(x) ((((uint64_t)htonl(x)) << 32) + htonl((x) >> 32))
- return htonll_r(i);
+ uint32_t lower_32_bits = static_cast<uint32_t>(i);
Review comment:
agree that it is not in scope
👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
