kent-nguyen commented on a change in pull request #4423:
URL: https://github.com/apache/nifi/pull/4423#discussion_r463908965
##########
File path:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/FetchS3Object.java
##########
@@ -166,13 +166,18 @@ public void onTrigger(final ProcessContext context, final
ProcessSession session
final ObjectMetadata metadata = s3Object.getObjectMetadata();
if (metadata.getContentDisposition() != null) {
final String fullyQualified = metadata.getContentDisposition();
- final int lastSlash = fullyQualified.lastIndexOf("/");
- if (lastSlash > -1 && lastSlash < fullyQualified.length() - 1)
{
- attributes.put(CoreAttributes.PATH.key(),
fullyQualified.substring(0, lastSlash));
- attributes.put(CoreAttributes.ABSOLUTE_PATH.key(),
fullyQualified);
- attributes.put(CoreAttributes.FILENAME.key(),
fullyQualified.substring(lastSlash + 1));
+
+ if
(fullyQualified.equals(PutS3Object.CONTENT_DISPOSITION_INLINE) ||
fullyQualified.equals(PutS3Object.CONTENT_DISPOSITION_ATTACHMENT)) {
Review comment:
@turcsanyip I have rebased my branch on main. I have also updated the PR
to update the variable name and correct the condition as requested. Please let
me know if there's anything else I can do. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
