hunyadi-dev commented on a change in pull request #837:
URL: https://github.com/apache/nifi-minifi-cpp/pull/837#discussion_r464233574
##########
File path: libminifi/src/core/logging/LoggerConfiguration.cpp
##########
@@ -298,22 +299,23 @@ std::shared_ptr<spdlog::sinks::sink>
LoggerConfiguration::create_syslog_sink() {
#ifdef WIN32
return std::make_shared<internal::windowseventlog_sink>("ApacheNiFiMiNiFi");
#else
- return std::make_shared<spdlog::sinks::syslog_sink>("ApacheNiFiMiNiFi");
+ return
std::dynamic_pointer_cast<spdlog::sinks::sink>(spdlog::syslog_logger_mt("ApacheNiFiMiNiFi",
0, LOG_USER, false));
Review comment:
I tried doing the suggested change before updating the PR, but
unfortunately it does not compile.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
