turcsanyip commented on a change in pull request #4438: URL: https://github.com/apache/nifi/pull/4438#discussion_r464509459
########## File path: nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/test/java/org/apache/nifi/processors/azure/storage/ITListAzureDataLakeStorage.java ########## @@ -0,0 +1,235 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.processors.azure.storage; + +import org.apache.nifi.processor.Processor; +import org.apache.nifi.processors.azure.AbstractAzureDataLakeStorageProcessor; +import org.apache.nifi.reporting.InitializationException; +import org.apache.nifi.serialization.record.MockRecordWriter; +import org.apache.nifi.util.MockFlowFile; +import org.junit.Before; +import org.junit.Test; + +import java.util.Arrays; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import static org.junit.Assert.assertNotNull; + +public class ITListAzureDataLakeStorage extends AbstractAzureDataLakeStorageIT { + + private Map<String, TestFile> testFiles; + + @Override + protected Class<? extends Processor> getProcessorClass() { + return ListAzureDataLakeStorage.class; + } + + @Before + public void setUp() { + testFiles = new HashMap<>(); + + TestFile testFile1 = new TestFile("", "file1"); + uploadFile(testFile1); + testFiles.put(testFile1.getFilePath(), testFile1); + + TestFile testFile2 = new TestFile("", "file2"); + uploadFile(testFile2); + testFiles.put(testFile2.getFilePath(), testFile2); + + TestFile testFile11 = new TestFile("dir1", "file11"); + createDirectoryAndUploadFile(testFile11); + testFiles.put(testFile11.getFilePath(), testFile11); + + TestFile testFile12 = new TestFile("dir1", "file12"); + uploadFile(testFile12); + testFiles.put(testFile12.getFilePath(), testFile12); + + TestFile testFile111 = new TestFile("dir1/dir11", "file111"); + createDirectoryAndUploadFile(testFile111); + testFiles.put(testFile111.getFilePath(), testFile111); + + TestFile testFile21 = new TestFile("dir 2", "file 21"); + createDirectoryAndUploadFile(testFile21); + testFiles.put(testFile21.getFilePath(), testFile21); + + createDirectory("dir3"); + } + + @Test + public void testListRootRecursive() throws Exception { + runner.setProperty(AbstractAzureDataLakeStorageProcessor.DIRECTORY, ""); + + runProcessor(); + + assertSuccess("file1", "file2", "dir1/file11", "dir1/file12", "dir1/dir11/file111", "dir 2/file 21"); + } + + @Test + public void testListRootNonRecursive() throws Exception { + runner.setProperty(AbstractAzureDataLakeStorageProcessor.DIRECTORY, ""); + runner.setProperty(ListAzureDataLakeStorage.RECURSE_SUBDIRECTORIES, "false"); + + runProcessor(); + + assertSuccess("file1", "file2"); + } + + @Test + public void testListSubdirectoryRecursive() throws Exception { + runner.setProperty(AbstractAzureDataLakeStorageProcessor.DIRECTORY, "dir1"); + + runProcessor(); + + assertSuccess("dir1/file11", "dir1/file12", "dir1/dir11/file111"); + } + + @Test + public void testListSubdirectoryNonRecursive() throws Exception { + runner.setProperty(AbstractAzureDataLakeStorageProcessor.DIRECTORY, "dir1"); + runner.setProperty(ListAzureDataLakeStorage.RECURSE_SUBDIRECTORIES, "false"); + + runProcessor(); + + assertSuccess("dir1/file11", "dir1/file12"); + } + + @Test + public void testListWithFileFilter() throws Exception { + runner.setProperty(AbstractAzureDataLakeStorageProcessor.DIRECTORY, ""); + runner.setProperty(ListAzureDataLakeStorage.FILE_FILTER, "file1.*"); + + runProcessor(); + + assertSuccess("file1", "dir1/file11", "dir1/file12", "dir1/dir11/file111"); + } + + @Test + public void testListRootWithPathFilter() throws Exception { + runner.setProperty(AbstractAzureDataLakeStorageProcessor.DIRECTORY, ""); + runner.setProperty(ListAzureDataLakeStorage.PATH_FILTER, "dir1.*"); + + runProcessor(); + + assertSuccess("dir1/file11", "dir1/file12", "dir1/dir11/file111"); + } + + @Test + public void testListSubdirectoryWithPathFilter() throws Exception { + runner.setProperty(AbstractAzureDataLakeStorageProcessor.DIRECTORY, "dir1"); + runner.setProperty(ListAzureDataLakeStorage.PATH_FILTER, "dir1.*"); + + runProcessor(); + + assertSuccess("dir1/dir11/file111"); + } + + @Test + public void testListRootWithFileAndPathFilter() throws Exception { + runner.setProperty(AbstractAzureDataLakeStorageProcessor.DIRECTORY, ""); + runner.setProperty(ListAzureDataLakeStorage.FILE_FILTER, ".*11"); + runner.setProperty(ListAzureDataLakeStorage.PATH_FILTER, "dir1.*"); + + runProcessor(); + + assertSuccess("dir1/file11", "dir1/dir11/file111"); + } + + @Test + public void testListEmptyDirectory() throws Exception { + runner.setProperty(AbstractAzureDataLakeStorageProcessor.DIRECTORY, "dir3"); + + runProcessor(); + + assertSuccess(); + } + + @Test + public void testListNonExistingDirectory() throws Exception { + runner.setProperty(AbstractAzureDataLakeStorageProcessor.DIRECTORY, "dummy"); + + runProcessor(); + + assertFailure(); + } + + @Test + public void testListWithNonExistingFileSystem() { + runner.setProperty(AbstractAzureDataLakeStorageProcessor.FILESYSTEM, "dummy"); + runner.setProperty(AbstractAzureDataLakeStorageProcessor.DIRECTORY, ""); + + runProcessor(); + + assertFailure(); + } + + @Test + public void testListWithRecords() throws InitializationException { + runner.setProperty(AbstractAzureDataLakeStorageProcessor.DIRECTORY, "dir1"); + + MockRecordWriter recordWriter = new MockRecordWriter(null, false); + runner.addControllerService("record-writer", recordWriter); + runner.enableControllerService(recordWriter); + runner.setProperty(ListAzureDataLakeStorage.RECORD_WRITER, "record-writer"); + + runner.run(); + + runner.assertAllFlowFilesTransferred(ListAzureDataLakeStorage.REL_SUCCESS, 1); + MockFlowFile flowFile = runner.getFlowFilesForRelationship(ListAzureDataLakeStorage.REL_SUCCESS).get(0); + flowFile.assertAttributeEquals("record.count", "3"); + } + + private void runProcessor() { + runner.assertValid(); + runner.run(); + } + + private void assertSuccess(String... testFilePaths) throws Exception { + runner.assertTransferCount(ListAzureDataLakeStorage.REL_SUCCESS, testFilePaths.length); + + Map<String, TestFile> expectedFiles = new HashMap<>(testFiles); + expectedFiles.keySet().retainAll(Arrays.asList(testFilePaths)); + + List<MockFlowFile> flowFiles = runner.getFlowFilesForRelationship(ListAzureDataLakeStorage.REL_SUCCESS); + + for (MockFlowFile flowFile : flowFiles) { + String filePath = flowFile.getAttribute("azure.filePath"); + TestFile testFile = expectedFiles.remove(filePath); + assertNotNull("File path not found in the expected map", testFile); + assertFlowFile(testFile, flowFile); + } + } + + private void assertFlowFile(TestFile testFile, MockFlowFile flowFile) throws Exception { + flowFile.assertAttributeEquals("azure.filesystem", fileSystemName); + flowFile.assertAttributeEquals("azure.filePath", testFile.getFilePath()); + flowFile.assertAttributeEquals("azure.directory", testFile.getDirectory()); + flowFile.assertAttributeEquals("azure.filename", testFile.getFilename()); + flowFile.assertAttributeEquals("azure.length", String.valueOf(testFile.getFileContent().length())); + + flowFile.assertAttributeExists("azure.lastModified"); + flowFile.assertAttributeExists("azure.etag"); + + flowFile.assertContentEquals(""); + } + + private void assertFailure() { Review comment: It is a failure case without sending FF to failure (List processors typically have only success and do not send FF on error). Added assert for checking the error logging. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
