tirkarthi commented on a change in pull request #4447:
URL: https://github.com/apache/nifi/pull/4447#discussion_r465089951
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ControllerServiceResource.java
##########
@@ -464,6 +464,10 @@ public Response updateControllerServiceReferences(
required = true
) final UpdateControllerServiceReferenceRequestEntity
requestUpdateReferenceRequest) {
+ if (requestUpdateReferenceRequest == null) {
+ throw new IllegalArgumentException("The controller service
information must be specified.");
+ }
+
if (requestUpdateReferenceRequest.getId() == null) {
Review comment:
You can probably club the conditional here
```
if(requestUpdateReferenceRequest == null ||
requestUpdateReferenceRequest.getId() == null)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
