mcgilman commented on a change in pull request #4449:
URL: https://github.com/apache/nifi/pull/4449#discussion_r465922789
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/frontend/package-lock.json
##########
@@ -144,20 +144,20 @@
"resolved": "https://registry.npmjs.org/d3-brush/-/d3-brush-1.0.4.tgz";,
"integrity": "sha1-AMLyOAGfJPbAoZSibUGhUw/+e8Q=",
"requires": {
- "d3-dispatch": "1.0.3",
- "d3-drag": "1.2.1",
- "d3-interpolate": "1.1.6",
- "d3-selection": "1.3.0",
- "d3-transition": "1.1.1"
+ "d3-dispatch": "1",
Review comment:
@scottyaslan @sardell I think I misunderstood the top-level dependency
comment. It looks like all dependencies (transitive or not) will be 'top-level'
in the package-lock.json. These will have explicit versions and will ensure
repeatable builds assuming we use it in our builds.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
