adamdebreceni commented on a change in pull request #866:
URL: https://github.com/apache/nifi-minifi-cpp/pull/866#discussion_r468373369
##########
File path: extensions/libarchive/MergeContent.cpp
##########
@@ -342,6 +362,56 @@ std::shared_ptr<core::FlowFile>
ZipMerge::merge(core::ProcessContext *context, c
return flowFile;
}
+void AttributeMerger::mergeAttributes() {
+ std::map<std::string, std::string> commonAttributes = getCommonAttributes();
Review comment:
we could do without the local variable, also I would rename
`getCommonAttributes` to `getMergedAttributes` (or something else) as "common"
has a specific meaning in this context, i.e. attributes that have the same
value in all flowFiles, (similarly for the parameter `commonAttributes` in the
`processFlowFile` methods)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
