szaszm commented on a change in pull request #871:
URL: https://github.com/apache/nifi-minifi-cpp/pull/871#discussion_r469841552
##########
File path: extensions/jni/jvm/JVMLoader.h
##########
@@ -349,7 +349,7 @@ class JVMLoader {
}
#ifdef _MSC_VER
-#pragma warning( suppress: 4054 )
Review comment:
missed space before closing paren
##########
File path: main/AgentDocs.cpp
##########
@@ -129,7 +129,7 @@ void AgentDocs::generate(const std::string &docsdir,
std::ostream &genStream) {
auto fileFind = [&fileList,this](const std::string& base_path, const
std::string& file) -> bool {
if (file.find(".extra") == std::string::npos)
- fileList.insert( std::make_pair(file, base_path +
utils::file::FileUtils::get_separator() + file) );
+ fileList.insert(std::make_pair(file, base_path +
utils::file::FileUtils::get_separator() + file) );
Review comment:
missed space before last closing paren
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
