adamdebreceni commented on a change in pull request #877:
URL: https://github.com/apache/nifi-minifi-cpp/pull/877#discussion_r475690750
##########
File path: extensions/rocksdb-repos/RocksDbStream.h
##########
@@ -160,7 +160,7 @@ class RocksDbStream : public io::BaseStream {
std::string value_;
- rocksdb::DB *db_;
+ gsl::not_null<minifi::internal::RocksDatabase*> db_;
Review comment:
but since nobody seems to share this feeling (here or the "internet") I
will modify the constructor to take a reference 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
