fgerlits commented on a change in pull request #887:
URL: https://github.com/apache/nifi-minifi-cpp/pull/887#discussion_r482114904
##########
File path: libminifi/include/utils/GeneralUtils.h
##########
@@ -68,6 +68,21 @@ using void_t = void;
using std::void_t;
#endif /* < C++17 */
+namespace internal {
+
+struct safe_enable_shared_from_this_base :
std::enable_shared_from_this<safe_enable_shared_from_this_base> {
Review comment:
Okay thanks, that's clear now. Can you add a comment somewhere
explaining that we need this code because `std::enable_shared_from_this` does
not play nice with multiple inheritance (or a link to an explanation, if there
is a good one somewhere public and durable)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
