lordgamez commented on a change in pull request #891:
URL: https://github.com/apache/nifi-minifi-cpp/pull/891#discussion_r484783119
##########
File path: extensions/windows-event-log/tests/ConsumeWindowsEventLogTests.cpp
##########
@@ -367,27 +372,19 @@ void batchCommitSizeTestHelper(int batch_commit_size, int
expected_num_commits)
test_plan->reset();
LogTestController::getInstance().resetStream(LogTestController::getInstance().log_output);
- {
- reportEvent(APPLICATION_CHANNEL, "Event one");
- reportEvent(APPLICATION_CHANNEL, "Event two");
- reportEvent(APPLICATION_CHANNEL, "Event three");
- reportEvent(APPLICATION_CHANNEL, "Event four");
- reportEvent(APPLICATION_CHANNEL, "Event five");
-
- test_controller.runSession(test_plan);
-
- REQUIRE(LogTestController::getInstance().countOccurrences("processQueue
commit") == expected_num_commits);
- }
+ std::vector<std::string> events{"Event one", "Event two", "Event three",
"Event four", "Event five"};
+ std::for_each(events.begin(), events.end(), [](const std::string& event){
reportEvent(APPLICATION_CHANNEL, event.c_str()); });
+ test_controller.runSession(test_plan);
+ auto expected_event_count = events.size() <= batch_commit_size ||
batch_commit_size == 0 ? events.size() : batch_commit_size;
+ REQUIRE(LogTestController::getInstance().contains("processed " +
std::to_string(expected_event_count) + " Events"));
}
} // namespace
TEST_CASE("ConsumeWindowsEventLog batch commit size works", "[onTrigger]") {
- batchCommitSizeTestHelper(1000, 1);
- batchCommitSizeTestHelper(5, 1);
- batchCommitSizeTestHelper(4, 2);
- batchCommitSizeTestHelper(3, 2);
- batchCommitSizeTestHelper(2, 3);
- batchCommitSizeTestHelper(1, 5);
- batchCommitSizeTestHelper(0, 1);
+ batchCommitSizeTestHelper(1000);
+ batchCommitSizeTestHelper(5);
+ batchCommitSizeTestHelper(4);
+ batchCommitSizeTestHelper(1);
+ batchCommitSizeTestHelper(0);
Review comment:
You are right, I made it more explicit in
[fa06429](https://github.com/apache/nifi-minifi-cpp/pull/891/commits/fa064298d99a1e0efc2609548062efd5f815085a)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
