[ 
https://issues.apache.org/jira/browse/NIFI-2731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530925#comment-15530925
 ] 

ASF GitHub Bot commented on NIFI-2731:
--------------------------------------

Github user mosermw commented on the issue:

    https://github.com/apache/nifi/pull/1071
  
    For backwards compatibility purposes, I think changing the default 100 
Maximum Number of Bins to 5 will have a large impact on users.  Right now most 
people just leave this at the default.  If they upgrade NiFi and they were 
regularly using 10 bins, for instance, then after the upgrade their 
MergeContent will behave a LOT differently.
    
    What memory footprint are we targetting for this change?  Even with a 512 
MB heap, 100 bins does not cause problems.
    
    I have really big concerns about this one.  Can we discuss more?


> MergeContent default max number of flow files and max number of bins should 
> be smaller
> --------------------------------------------------------------------------------------
>
>                 Key: NIFI-2731
>                 URL: https://issues.apache.org/jira/browse/NIFI-2731
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Joseph Witt
>            Assignee: Pierre Villard
>             Fix For: 1.1.0
>
>
> Presently there is no default on max entries.  It should probably be set to 
> 1000 by default.  These are flow files and their objects are read into memory 
> and can add up quickly.  Further, if we have 100 default max bins we could 
> end up with 100s of thousands of flow file objects held in memory during 
> common dataflow scenarios.  Recommend moving to max 5 different bins by 
> default and max 1000 flow files by default.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to