[ 
https://issues.apache.org/jira/browse/NIFI-7804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17195681#comment-17195681
 ] 

Bryan Bende commented on NIFI-7804:
-----------------------------------

Discussed offline with [~alopresto]  and [~markap14] and we discussed two 
changes for this ticket...
 * Splitting _nifi-security-utils_ into two modules, the first would be 
_nifi-security-utils-core_ which would have no dependencies and would be safe 
to use in _nifi-standard-services-api_, and then _nifi-security-utils_ would 
depend on _nifi-security-utils-core_ and would include all the other utility 
code that requires bouncy castle, etc.
 * Restore the ClientAuth enum to SSLContextService and make it extend an enum 
from nifi-security-utils-core

The first changed addresses the classpath issue outline in this ticket, and the 
second change ensures that SSLContextService from 1.12.0 is backward compatible 
for any extensions built against an older version.

> Dependencies ending up in nifi-standard-services-api
> ----------------------------------------------------
>
>                 Key: NIFI-7804
>                 URL: https://issues.apache.org/jira/browse/NIFI-7804
>             Project: Apache NiFi
>          Issue Type: Bug
>    Affects Versions: 1.10.0, 1.11.0, 1.12.0, 1.11.1, 1.11.2, 1.11.3, 1.11.4
>            Reporter: Bryan Bende
>            Assignee: Bryan Bende
>            Priority: Critical
>             Fix For: 1.13.0, 1.12.1
>
>
> One of the changes in https://issues.apache.org/jira/browse/NIFI-7407 was a 
> refactoring to the SSLContextService interface which added classes from 
> nifi-security-utils. The result is that nifi-standard-services-api-nar now 
> has transitive dependencies of nifi-security-utils included...
> {code:java}
> bcpkix-jdk15on-1.66.jar
> bcprov-jdk15on-1.66.jar
> bcrypt-0.9.0.jar
> bytes-1.3.0.jar
> commons-codec-1.14.jar
> commons-lang3-3.9.jar {code}
> This means any NAR that has a parent of nifi-standard-services-api-nar, which 
> is most of them, now has these on the classpath which may conflict with 
> versions of the same libraries used in the child NAR.
> We should come up with a way to not depend on nifi-security-utils, or split 
> it up into more isolated modules so that these dependencies don't get brought 
> in to the service APIs.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to