mattyb149 commented on a change in pull request #4522:
URL: https://github.com/apache/nifi/pull/4522#discussion_r488639477
##########
File path:
nifi-nar-bundles/nifi-extension-utils/nifi-prometheus-utils/src/main/java/org/apache/nifi/prometheus/util/PrometheusMetricsUtil.java
##########
@@ -249,10 +249,8 @@ public static CollectorRegistry
createNifiMetrics(NiFiMetricsRegistry nifiMetric
nifiMetricsRegistry.setDataPoint(portStatus.getBytesSent(),
"AMOUNT_BYTES_SENT", instanceId, portComponentType, portComponentName,
portComponentId, parentId);
nifiMetricsRegistry.setDataPoint(portStatus.getInputBytes(),
"AMOUNT_BYTES_READ", instanceId, portComponentType, portComponentName,
portComponentId, parentId);
nifiMetricsRegistry.setDataPoint(portStatus.getOutputBytes(),
"AMOUNT_BYTES_WRITTEN", instanceId, portComponentType, portComponentName,
portComponentId, parentId);
- nifiMetricsRegistry.incrementCounter(status.getBytesRead(),
"TOTAL_BYTES_READ", instanceId, portComponentType, portComponentName,
portComponentId, parentId);
- nifiMetricsRegistry.incrementCounter(status.getBytesWritten(),
"TOTAL_BYTES_WRITTEN", instanceId, portComponentType, portComponentName,
portComponentId, parentId);
-
nifiMetricsRegistry.incrementCounter(status.getBytesReceived(),
"TOTAL_BYTES_RECEIVED", instanceId, portComponentType, portComponentName,
portComponentId, parentId);
- nifiMetricsRegistry.incrementCounter(status.getBytesSent(),
"TOTAL_BYTES_SENT", instanceId, portComponentType, portComponentName,
portComponentId, parentId);
+
nifiMetricsRegistry.incrementCounter(portStatus.getBytesReceived(),
"TOTAL_BYTES_RECEIVED", instanceId, portComponentType, portComponentName,
portComponentId, parentId);
+
nifiMetricsRegistry.incrementCounter(portStatus.getBytesSent(),
"TOTAL_BYTES_SENT", instanceId, portComponentType, portComponentName,
portComponentId, parentId);
Review comment:
Good catch, I saw the behavior while doing some additional testing.
Since the second commit isn't valid, I'll just correct the original and
force-push
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
