ottobackwards commented on a change in pull request #4531: URL: https://github.com/apache/nifi/pull/4531#discussion_r488863008
########## File path: nifi-nar-bundles/nifi-prometheus-bundle/nifi-prometheus-reporting-task/src/main/java/org/apache/nifi/reporting/prometheus/PrometheusRecordSink.java ########## @@ -181,15 +183,23 @@ public WriteResult sendData(RecordSet recordSet, Map<String, String> attributes, @OnDisabled public void onStopped() throws Exception { Review comment: this api would be a good place to use Optional<T> ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org