yoshiata commented on a change in pull request #2997:
URL: https://github.com/apache/nifi/pull/2997#discussion_r489976543



##########
File path: 
nifi-nar-bundles/nifi-cdc/nifi-cdc-mysql-bundle/nifi-cdc-mysql-processors/src/main/java/org/apache/nifi/cdc/mysql/processors/CaptureChangeMySQL.java
##########
@@ -681,6 +731,9 @@ protected void connect(List<InetSocketAddress> hosts, 
String username, String pa
                 binlogClient.setBinlogPosition(currentBinlogPosition);
             }
 
+            binlogClient.setGtidSet(currentGtidSet);
+            binlogClient.setGtidSetFallbackToPurged(true);

Review comment:
       @pvillard31 We need it to realize the following:
   
   - The processor can get the binlog even if the binlog is purged on the 
connected host.
   - When reconnecting to another host, the processor can get the binlog even 
if the binlog is already purged on that host.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to