alopresto commented on a change in pull request #302:
URL: https://github.com/apache/nifi-registry/pull/302#discussion_r490509341
##########
File path:
nifi-registry-core/nifi-registry-security-utils/src/main/java/org/apache/nifi/registry/security/util/ProxiedEntitiesUtils.java
##########
@@ -39,6 +41,55 @@
private static final String ANONYMOUS_CHAIN = "<>";
+ /**
+ * Formats a list of DN/usernames to be set as a HTTP header using well
known conventions.
+ *
+ * @param proxiedEntities the raw identities (usernames and DNs) to be
formatted as a chain
+ * @return the value to use in the X-ProxiedEntitiesChain header
+ */
+ public static String getProxiedEntitiesChain(final String[]
proxiedEntities) {
Review comment:
I think this accepts `String[]` because that's how the values were
previously stored, but now that the field is a plain `String` in the config
object, does it make sense to just use `List<String>` here for consistency &
convenience?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
